Activity

• psf/black repo issues and pull requests

  • Add script to ease migration to black #3038 [hbrunn]

    Description I was looking for a script to update existing feature branches automatically when introducing black in...

    • hbrunn: thanks for the reviews, now correctly formatted, using logging and with a changelog entry

  • Docs: clarify fmt:on/off requirements #3048 [felix-hilden] skip news

    Description A small clarification about our requirements for # fmt: on/off, prompted by #2985 (does not...

  • Docstrings reformatted to be too long #1632 [mlissner] T: bug F: strings / docstrings

    Describe the bug When there's a docstring that's near the max line length with the """ on the next line, the new...

  • Fail gracefully when unaligned or missing 'fmt: off/on' found #2985 [mvaled] T: bug F: fmtoff

    The following snippet makes black fail with "Black produced code that is not equivalent to the source.". import...

    • JelleZijlstra: Agree, this sort of code is incorrect and Black should fail on it, but we should fail gracefully...

  • Docstring too long (issue #1632 fix) #3044 [idorrington92]

    Description Fixing this issue #1632 where some docstrings were reformatted to be too long Checklist - did you...

    • JelleZijlstra

    • ichard26: Congrats on your first merged PR to black @idorrington92! 🎉

  • Read simple data cases automatically #3034 [saroad2] skip news

    Description When testing black formatting, the simple use cases where defined hard-coded in a list named...

    • saroad2: Hey everyone, thanks for the review @ichard26's suggested API will work just fine at the moment...

    • felix-hilden: That works! And we make non-changelog changes happen using a label which I applied just now 👍...

    • saroad2: Great! I made all the changes we've discussed. @felix-hilden , I really don't need that entry in...

    • felix-hilden

    • JelleZijlstra

  • Literal string not formatted correctly #3060 [thedemons] T: bug

    For some reason, the shorter line is formatted but the longer one isn't To Reproduce These lines of...

    • felix-hilden: The shorter line fits the line length after formatting. The longer cannot, but when --preview is...

    • thedemons: The shorter line fits the line length after formatting. The longer cannot, but when --preview is...

    • felix-hilden: What's your situation exactly? Doesn't do that for me: PW_PATTERN = ( "08 00 00 00 09 00 00...

  • Remove newline after `def` statement #3035 [saroad2]

    Description Fixes #902 Newlines are great. They help us organize our code and leave room for the coders and...

    • saroad2: Thank for the feedback @felix-hilden . Let's see what other reviewers say and if all agree, I...

    • felix-hilden: As discussed on the issue, I'd be open to removing all newlines at the beginning of blocks. I...

    • github-actions: diff-shades results comparing this PR (10a299c) to main (fc2a164). The full diff is available in...

  • fmt: skip removes a comment-only line before it #2339 [felix-hilden] T: bug C: invalid code F: comments F: fmtskip

    Describe the bug Comments behave oddly before # fmt: skip lines. To Reproduce 1 # fmt: skip This works as expected:...

  • fmt: on and other comments before fmt: skip removed #3061 [felix-hilden] T: bug R: duplicate C: invalid code F: fmtskip

    Describe the bug # fmt: on and other comment-only lines are removed before a line with # fmt: skip. To Reproduce #...

    • felix-hilden: Ah, indeed this was a duplicate of #2339.

  • Document new Microsoft Black Formatter extension for VSCode #3063 [laundmo] T: documentation C: integrations skip news

    Description VSCode announced a new extension for Black in their update notes for version 1.67.0, this PR adds a...

    • cooperlees: Seems helpful for readers. Please just fix the lint.

      • cooperlees: Why was this indented? I think this is what is making linting upset.

  • Black module coredumps numerous times when PyCharm updates its indices #3064 [ajgringo619] T: bug

    Describe the bug Whenever PyCharm CE decides to download/update its indices, I get 10+ coredump messages in the...

  • Remove hard coded test cases #3062 [saroad2] C: cleanup skip news C: maintenance

    Description This PR is a continuation of #3034. The end goal of thus PR is to move all cases in the tests/data...

    • saroad2: @felix-hilden , could you please add the "skip news" label to this PR so the CI would pass?

    • felix-hilden: HUGE! 🎉 Some comments below. Do you think changing the read_data interface (and I guess that...

      • felix-hilden: Should we also walk the source directories here and get all of the Python files?

        • saroad2: I believe that the right thing to do is to add the following step/job to the CI process: pip...

        • felix-hilden: True, it appears we only check each file with default params, so that would work. I don't have a...

      • felix-hilden: Very nice refactors all over 👍

        • saroad2: Thanks!

      • felix-hilden: Just noting that this changed, but I guess it can't hurt to test all the cases!

        • saroad2: I thought that this is the right thing to do, because the test is not specific for...

    • saroad2: Hey @felix-hilden. This is still a draft because I'm not done yet :) I want to try and move all...

    • saroad2: This PR is now ready for review :)

    • felix-hilden: Thanks again! Overall, I like the categorisation and it's nice that most individual test...

      • felix-hilden: Suggested change ...

      • felix-hilden: Suggested change ...

      • felix-hilden: Suggested change ...

      • felix-hilden: Suggested change ...

      • felix-hilden: Suggested change ...

      • felix-hilden: Suggested change ...

      • felix-hilden: Suggested change ...

      • felix-hilden: If we wanted to, we could try to avoid specifying "preview_39" twice (and in other similar...

        • saroad2: We could, but I think it might cause more changes in code. It's probably worth another PR.

    • saroad2: Having a directory for a single fast is a bit awkward 😄 how about misc? I'm pretty sure there...

  • Line too long: Dictionary key-value pair #413 [ghost] T: bug F: parentheses F: linetoolong F: linebreak

    Hey, with black, version 18.6b4 I am getting two lines within dict merged resulting in line exceeding provided...

    • berzi: Any update on a solution for this bug?

    • felix-hilden: Any updates will be posted here!

  • Ugly string concat #3066 [blankRiot96] T: design F: strings / docstrings

    Describe the style change Black made this unusual ugly change to my code after I made the string longer. Examples in...

    • felix-hilden: Applying --preview will use our new string processing to merge the two strings. Would that...

    • blankRiot96: @felix-hilden Hey, thanks for the reply That's definitely better, but not my desired code...

    • JelleZijlstra: We default line length to 88, though you can set it to 79 and preview mode should keep the string split.

created at 2022-05-10 13:40 by dinghy 0.11.4.